Re: [PATCH v2] ALSA: hda: cs35l56: Fix missing RESET GPIO if _SUB is missing

From: Takashi Iwai
Date: Fri Sep 15 2023 - 06:27:51 EST


On Thu, 14 Sep 2023 17:25:25 +0200,
Richard Fitzgerald wrote:
>
> In cs35l56_hda_read_acpi() do not return if ACPI _SUB is missing.
>
> A missing _SUB means that the driver cannot load a system-specific
> firmware, because the firmware is identified by the _SUB. But it can
> fallback to a generic firmware. Unfortunately this was being handled
> by immediately returning 0, which would skip the remaining ACPI
> configuration in cs35l56_hda_read_acpi() and so it would not get the
> RESET GPIO.
>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")

Thanks, applied now.


Takashi