Re: [PATCH] workqueue: Removed double allocation of wq_update_pod_attrs_buf

[Geert Uytterhoeven]

On Thu, Sep 7, 2023 at 8:46 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
>
> First commit 2930155b2e272 ("workqueue: Initialize unbound CPU pods later in
> the boot") added the initialization of wq_update_pod_attrs_buf to
> workqueue_init_early(), and then latter on, commit 84193c07105c6
> ("workqueue: Generalize unbound CPU pods") added it as well. This appeared
> in a kmemleak run where the second allocation made the first allocation
> leak.
>
> Fixes: 84193c07105c6 ("workqueue: Generalize unbound CPU pods")
> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

Just noticed this, too.
John posted a similar patch after you:
https://lore.kernel.org/all/20230913101634.553699-1-john.ogness@xxxxxxxxxxxxx/

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds