Re: [PATCH 7/9] arm64: dts: qcom: msm8916/39: Disable unneeded firmware reservations

[Stephan Gerhold]

On Fri, Sep 15, 2023 at 03:51:03PM +0200, Konrad Dybcio wrote:
> On 11.09.2023 19:41, Stephan Gerhold wrote:
> > Now that we no longer have fixed addresses for the firmware memory
> > regions, disable them by default and only enable them together with
> > the actual user in the board DT.
> > 
> > This frees up unnecessary reserved memory for boards that do not use
> > some of the remoteprocs and allows moving selected device-specific
> > properties (such as firmware size) to the board-specific DT part in
> > the next step.
> > 
> > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> > ---
> Wouldn't delete-node on the outliers be more concise?
> 

No, because you also need to delete the reference to it on the
remoteproc node, i.e.

	/delete-node/ &wcnss_mem;

	&wcnss {
		/delete-property/ memory-region;
	};

But IMO this would be inconsistent anyway. You already have to opt-in to
get WCNSS at all (i.e.

	&wcnss {
		status = "okay";
	};

), so it would be weird to have the memory region opt-out IMO.

Thanks,
Stephan