Re: [PATCH v2 2/2] dt-bindings: hwmon: add MAX31790

[Conor Dooley]

Yo,

On Fri, Sep 15, 2023 at 02:29:24PM +0800, Delphine CC Chiu wrote:
> Add dt-bindings for the MAXIM MAX31790.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> ---
> Changelog:
> v2 - Add dt-bindings for the MAXIM MAX31790.
> ---
>  .../bindings/hwmon/maxim,max31790.yaml        | 59 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> new file mode 100644
> index 000000000000..2bd455b36b3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim max31790
> +
> +maintainers:
> +  - Delphine CC Chiu  <Delphine_CC_Chiu@xxxxxxxxxx>
> +
> +description: |
> +  The MAX31790 controls the speeds of up to six fans using
> +  six independent PWM outputs. The desired fan speeds (or PWM duty cycles)
> +  are written through the I2C	interface.
> +  The outputs drive “4-wire” fans directly, or can be used to modulate
> +  the fan’s power terminals using an external pass transistor.
> +
> +  Datasheets:
> +    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - maxim,max31790
> +
> +  reg:
> +    maxItems: 1
> +
> +  pwm-as-tach:

I don't see any other users of this in-tree, so you'd need a vendor
prefix. That said, I'm once bitten, twice shy about fan related
properties in hwmon, so I would definitely like Rob to comment on this
whole binding.

> +    description: |
> +      There are 6 PWM output channel in MAX31790 that allows to be configured
> +      as a TACH input by setting the Fan Configuration register.
> +      Config PWM output channels in the array as tachometer inputs.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 1
> +    maxItems: 6
> +    items:
> +      enum: [1, 2, 3, 4, 5, 6]
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      pwm@20 {
> +        compatible = "maxim,max31790";
> +        reg = <0x20>;
> +        pwm-as-tach = <2 5>;

This would be <2>, <5>; no?

> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c8fdd0d03907..97e13b6bf51d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1371,6 +1371,12 @@ F:	Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
>  F:	Documentation/hwmon/max31760.rst
>  F:	drivers/hwmon/max31760.c
>  
> +ANALOG DEVICES INC MAX31790 DRIVER
> +M:	Delphine CC Chiu  <Delphine_CC_Chiu@xxxxxxxxxx>
> +S:	Odd Fixes

This is a pretty odd status for something you're newly adding.
How come it's not going to be maintained?

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature