Re: [PATCH] mm/rmap: convert __page_check_anon_rmap() to folio

From: David Hildenbrand
Date: Fri Sep 15 2023 - 11:28:00 EST


On 15.09.23 15:49, Matthew Wilcox wrote:
On Fri, Sep 15, 2023 at 06:17:31PM +0800, Yajun Deng wrote:
@@ -1176,8 +1175,8 @@ static void __page_check_anon_rmap(struct folio *folio, struct page *page,
*/
VM_BUG_ON_FOLIO(folio_anon_vma(folio)->root != vma->anon_vma->root,
folio);
- VM_BUG_ON_PAGE(page_to_pgoff(page) != linear_page_index(vma, address),
- page);
+ VM_BUG_ON_FOLIO(folio_pgoff(folio) != linear_page_index(vma, address),
+ folio);

No, this is not equivalent. You haven't hit any problems testing it
because you don't have large anonymous folios.

Right, the address would have to be adjusted as well by the caller.

--
Cheers,

David / dhildenb