Re: [PATCH] x86/sev: Make early_set_memory_decrypted() calls page aligned

From: Steve Rutherford
Date: Fri Sep 15 2023 - 14:49:01 EST


I believe V3 of this fix was already merged into both x86 and Linus'
tree (I think as ac3f9c9f1b37edaa7d1a9b908bc79d843955a1a2, "x86/sev:
Make enc_dec_hypercall() accept a size instead of npages").


On Fri, Sep 15, 2023 at 4:59 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Steve Rutherford <srutherford@xxxxxxxxxx> wrote:
>
> > early_set_memory_decrypted() assumes its parameters are page aligned.
> > Non-page aligned calls result in additional pages being marked as
> > decrypted via the encryption status hypercall, which results in
> > consistent corruption of pages during live migration. Live
> > migration requires accurate encryption status information to avoid
> > migrating pages from the wrong perspective.
> >
> > Fixes: 4716276184ec ("X86/KVM: Decrypt shared per-cpu variables when SEV is active")
> > Signed-off-by: Steve Rutherford <srutherford@xxxxxxxxxx>
> > ---
> > arch/x86/kernel/kvm.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
>
> I suppose this fix is going through the KVM tree, or should we pick it up
> in the x86 tree?
>
> Thanks,
>
> Ingo