Re: [RFC 04/23] filemap: set the order of the index in page_cache_delete_batch()

From: Matthew Wilcox
Date: Fri Sep 15 2023 - 15:44:35 EST


On Fri, Sep 15, 2023 at 08:38:29PM +0200, Pankaj Raghav wrote:
> From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
>
> Similar to page_cache_delete(), call xas_set_order for non-hugetlb pages
> while deleting an entry from the page cache.

Is this necessary? As I read xas_store(), if you're storing NULL, it
will wipe out all sibling entries. Was this based on "oops, no, it
doesn't" or "here is a gratuitous difference, change it"?