Re: [PATCH v3 0/3] perf: strcmp_cpuid_str() expression fixups

From: Namhyung Kim
Date: Sun Sep 17 2023 - 01:26:01 EST


Hello,

On Wed, Sep 13, 2023 at 8:34 AM James Clark <james.clark@xxxxxxx> wrote:
>
> Set of fixes related to the comments here [1]. Mainly cleanups,
> additional tests and refactoring since adding the new strcmp_cpuid_str()
> metric expression.
>
> I added the string replace function to the perf utils
> rather than tools/lib/string.c because it didn't seem
> easy to add tests for tools/lib.
>
> [1]: https://lore.kernel.org/linux-arm-kernel/CAP-5=fVnUx0BnJC7X1rrm42OD7Bk=ZsHWNwAZMBYyB7yWhBfhQ@xxxxxxxxxxxxxx/
> [2]: https://lore.kernel.org/linux-perf-users/ZQC7da2AM9ih8RMz@xxxxxxxxxx/
>
> ---
> Changes since v2:
> * Drop patches that were already applied (which makes the cover letter
> mostly redundant)
> * Avoid generating the compiler warning reported here [2]
>
> Changes since v1:
> * s -> haystack
> * find -> needle
>
> James Clark (3):
> perf pmu: Move pmu__find_core_pmu() to pmus.c
> perf pmus: Simplify perf_pmus__find_core_pmu()
> perf pmu: Remove unused function

Applied to perf-tools-next, thanks!