Re: [PATCH v1 1/1] ARM: dts: hpe: BUG: Correct GXP register ranges
From: Krzysztof Kozlowski
Date: Sun Sep 17 2023 - 04:37:23 EST
On 15/09/2023 18:54, charles.kearney@xxxxxxx wrote:
> From: Charles Kearney <charles.kearney@xxxxxxx>
>
> Bug fix to correct memory ranges on GXP to include host registers. This
> corrects a issue where the host interrupt controller is not available.
Then you miss Fixes tag. Maybe also Cc-stable tag.
>
> Signed-off-by: Charles Kearney <charles.kearney@xxxxxxx>
> ---
> arch/arm/boot/dts/hpe/hpe-gxp.dtsi | 39 +++++++++++++++---------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/boot/dts/hpe/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe/hpe-gxp.dtsi
> index cf735b3c4f35..18230a4754a6 100644
> --- a/arch/arm/boot/dts/hpe/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe/hpe-gxp.dtsi
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree file for HPE GXP
> + * Device Tree for HPE
How is this related to bug?
> */
>
> /dts-v1/;
> @@ -52,73 +52,74 @@ L2: cache-controller@b0040000 {
> cache-level = <2>;
> };
>
> - ahb@c0000000 {
> + ahb@80000000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x0 0xc0000000 0x30000000>;
> dma-ranges;
> + ranges = <0x0 0x80000000 0x20000000>,
> + <0x40000000 0xc0000000 0x3fff0000>;
Missing proper alignment.
Best regards,
Krzysztof