Re: [PATCH 1/2] Documentation: dt-bindings: media: i2c: Add ROHM BU64754 bindings

[Kieran Bingham]

Quoting Krzysztof Kozlowski (2023-09-17 10:37:07)
> On 15/09/2023 18:59, Kieran Bingham wrote:
> > Add YAML device tree bindings for the ROHM BU64754 VCM Motor Driver for
> > Camera Autofocus.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > ---
> 
> ...
> 
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - rohm,bu64754
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply:
> 
> If the supply is not required, how the driver gets any power?

It may not be controllable. It could be wired to be always on.

The device has a low power mode which is controllable by software, so it
could be always powered on and controlled via software only if desired.
The driver handles that already as if the regulator isn't specified the
power down register bits will be set to put it in low power mode.


> 
> > +    description:
> > +      Definition of the regulator used as VDD power supply to the driver.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        lens@76 {
> > +            compatible = "rohm,bu64754";
> > +            reg = <0x76>;
> > +            vdd-supply = <&cam1_reg>;
> > +        };
> > +    };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 90f13281d297..f43e0ffcaf56 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18570,6 +18570,13 @@ S:   Supported
> >  F:   drivers/iio/light/rohm-bu27008.c
> >  F:   drivers/iio/light/rohm-bu27034.c
> >  
> > +ROHM BU64754 MOTOR DRIVER FOR CAMERA AUTOFOCUS
> > +M:   Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > +L:   linux-media@xxxxxxxxxxxxxxx
> > +S:   Maintained
> > +T:   git git://linuxtv.org/media_tree.git
> 
> Do you have push rights there? The git entry is for entries where you
> maintain, which means: you accept and apply patches. This does not look
> like the case, so copying subsystem Git entry is pointless. Subsystem
> maintainer defines the git tree, not you.

I'll drop the line.

> 
> Best regards,
> Krzysztof
>