Re: [PATCH v4 30/42] input: keypad: ep93xx: add DT support for Cirrus EP93xx

[Andy Shevchenko]

On Fri, Sep 15, 2023 at 11:11:12AM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> 
> - drop flags, they were not used anyway
> - add OF ID match table
> - process "autorepeat", "debounce-delay-ms", prescale from device tree
> - drop platform data usage and it's header
> - keymap goes from device tree now on

...

>  #include <linux/bits.h>
>  #include <linux/module.h>
> +#include <linux/of.h>

Is this correct header? Shouldn't be property.h?

>  #include <linux/platform_device.h>

> +#include <linux/mod_devicetable.h>

Can you. please, try to squeeze them to most ordered parts?

>  #include <linux/interrupt.h>
>  #include <linux/clk.h>

-- 
With Best Regards,
Andy Shevchenko