Re: [PATCH v2 05/12] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA

From: David Woodhouse
Date: Mon Sep 18 2023 - 09:00:40 EST


On Mon, 2023-09-18 at 13:11 +0100, Paul Durrant wrote:
> On 18/09/2023 12:34, David Woodhouse wrote:
> > On Mon, 2023-09-18 at 11:21 +0000, Paul Durrant wrote:
> > > From: Paul Durrant <pdurrant@xxxxxxxxxx>
> > >
> > > Some cached pages may actually be overlays on guest memory that have a
> > > fixed HVA within the VMM. It's pointless to invalidate such cached
> > > mappings if the overlay is moved so allow a cache to be activated directly
> > > with the HVA to cater for such cases. A subsequent patch will make use
> > > of this facility.
> > >
> > > Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> >
> > Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> >
> > Btw, I think you have falsified some Reviewed-by: tags on the rest of
> > the series. Remember, if they aren't literally cut and pasted, the
> > magic gets lost. Just the same as Signed-off-by: tags. Never type them
> > for someone else.
>
> Indeed. They were all copied and pasted.

I'm prepared to believe my fingers betrayed me and autocompleted
@infradead.org for one or two of them when I meant to use the @amazon
address, but surely not *all* of them that I reviewed last time round?

:)

Attachment: smime.p7s
Description: S/MIME cryptographic signature