Re: [RFC PATCH 2/3] add statmnt(2) syscall

From: Miklos Szeredi
Date: Mon Sep 18 2023 - 12:35:50 EST


On Mon, Sep 18, 2023 at 3:51 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:

> I really would prefer a properly typed struct and that's what everyone
> was happy with in the session as well. So I would not like to change the
> main parameters.

I completely agree. Just would like to understand this point:

struct statmnt *statmnt(u64 mntid, u64 mask, unsigned int flags);

What's not properly typed about this interface?

I guess the answer is that it's not a syscall interface, which will
have an added [void *buf, size_t bufsize], while the buffer sizing is
done by a simple libc wrapper.

Do you think that's a problem? If so, why?

Thanks,
Miklos