Re: [PATCH 03/10] platform/x86/intel/ifs: Image loading for new generations

From: Joseph, Jithu
Date: Mon Sep 18 2023 - 12:52:03 EST




On 9/18/2023 9:29 AM, Ilpo Järvinen wrote:

>
> In this case it is not just about the bitfield itself nor the bit
> allocation order but sharing the storage unit with another member, and to
> further complicate things, members have different alignment requirement
> too (32-bit aligned u8 followed by u32 bitfield).
>

I too verified that the size of the whole structure matches that of MSR 64 bits (8 bytes).

Initially when IFS scan was added the all MSR structure members were bit-fields, later there was a suggestion to
use basic C types if applicable during subsequent Array BIST patch series. I followed this approach with the current patch series .

I will change the current series to use all bit-field MSR structures in v2, given mixing basic types and bitfields is a a source of confusion

Jithu