Re: [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible

[Sricharan Ramabadhran]

On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote:
> On 15/09/2023 14:43, Krzysztof Kozlowski wrote:
> > On 15/09/2023 14:15, Sricharan Ramabadhran wrote:
> > > IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
> > >
> > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > > ---
> > >   [v2] Sorted the compatible and removed example
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> No, unreviewed. Your driver says it is not compatible with
> qcom,tsens-v1. This does not look right :/

 Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS
 have to do those steps after calling init_common. Similar reason
 added a new feat as well in patch #2 as well. Hence for this,
 new compatible was required.

Regards,
 Sricharan