Re: [PATCH V2 3/4] thermal/drivers/tsens: Add support for IPQ5018 tsens

From: Sricharan Ramabadhran
Date: Tue Sep 19 2023 - 03:26:46 EST


<..>

+static int init_ipq5018(struct tsens_priv *priv)
+{
+ int ret;
+ u32 mask;
+
+ init_common(priv);

Please take care of init_common()'s return code. Don't continue init
if init_common() fails.

ok


+ if (!priv->tm_map)
+ return -ENODEV;

Why?

ok, redundant, will remove.

Regards,
Sricharan