Re: [PATCH v1 2/2] usb: chipidea: Add support for NPCM

From: kernel test robot
Date: Tue Sep 19 2023 - 03:49:15 EST


Hi Tomer,

kernel test robot noticed the following build errors:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master v6.6-rc2 next-20230918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Tomer-Maimon/dt-binding-usb-ci-hdrc-usb2-document-Nuvoton-NPCM-supprt/20230919-010147
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20230918165958.2659-3-tmaimon77%40gmail.com
patch subject: [PATCH v1 2/2] usb: chipidea: Add support for NPCM
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230919/202309191545.dZXS2Y2p-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309191545.dZXS2Y2p-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309191545.dZXS2Y2p-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/usb/chipidea/ci_hdrc_npcm.c: In function 'npcm_udc_probe':
>> drivers/usb/chipidea/ci_hdrc_npcm.c:68:17: error: 'CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS' undeclared (first use in this function)
68 | CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/chipidea/ci_hdrc_npcm.c:68:17: note: each undeclared identifier is reported only once for each function it appears in


vim +/CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS +68 drivers/usb/chipidea/ci_hdrc_npcm.c

39
40 static int npcm_udc_probe(struct platform_device *pdev)
41 {
42 int ret;
43 unsigned int args[3];
44 struct regmap *gcr_regmap;
45 struct npcm_udc_data *ci;
46 struct platform_device *plat_ci;
47 struct device *dev = &pdev->dev;
48 struct device_node *np = dev->of_node;
49
50 ci = devm_kzalloc(&pdev->dev, sizeof(*ci), GFP_KERNEL);
51 if (!ci)
52 return -ENOMEM;
53 platform_set_drvdata(pdev, ci);
54
55 ci->core_clk = devm_clk_get_optional(dev, NULL);
56 if (IS_ERR(ci->core_clk))
57 return PTR_ERR(ci->core_clk);
58
59 ret = clk_prepare_enable(ci->core_clk);
60 if (ret) {
61 dev_err(dev, "failed to enable the clock: %d\n", ret);
62 return ret;
63 }
64
65 ci->pdata.name = dev_name(dev);
66 ci->pdata.capoffset = DEF_CAPOFFSET;
67 ci->pdata.flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
> 68 CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS;
69 ci->pdata.phy_mode = USBPHY_INTERFACE_MODE_UTMI;
70 ci->pdata.notify_event = npcm_udc_notify_event;
71
72 gcr_regmap = syscon_regmap_lookup_by_phandle_args(np, "nuvoton,sysgcr",
73 3, args);
74 if (!IS_ERR(gcr_regmap))
75 regmap_update_bits(gcr_regmap, args[0], args[1], args[2]);
76
77 plat_ci = ci_hdrc_add_device(dev, pdev->resource, pdev->num_resources,
78 &ci->pdata);
79 if (IS_ERR(plat_ci)) {
80 ret = PTR_ERR(plat_ci);
81 dev_err(dev, "failed to register HDRC NPCM device: %d\n", ret);
82 goto clk_err;
83 }
84
85 pm_runtime_no_callbacks(dev);
86 pm_runtime_enable(dev);
87
88 return 0;
89
90 clk_err:
91 clk_disable_unprepare(ci->core_clk);
92 return ret;
93 }
94

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki