Re: [PATCH] firmware_loader: Add reboot_in_progress for user helper path
From: Greg KH
Date: Tue Sep 19 2023 - 04:34:48 EST
On Tue, Sep 19, 2023 at 01:27:05PM +0530, Mukesh Ojha wrote:
> > > +bool reboot_in_progress;
> >
> > Bad global name for a variable in the firmware_loader core.
>
> bool abort_fw_load_req ??
Use "noun_verb" please for global symbols so it's more obvious where the
symbol is, and it's a bit easier to manage the namespace.
thanks,
greg k-h