Re: [PATCH 4/4] net/onsemi: Add NCN26010 driver

[Paolo Abeni]

On Mon, 2023-09-18 at 21:54 -0500, Jay Monkman wrote:
> On Mon, Sep 18, 2023 at 06:00:37PM +0200, Andrew Lunn wrote:
> > Is this an OA TC6 device?  At a quick look it does appear to
> > be. Please make use of the framework Microchip is developing:
> > 
> > https://lore.kernel.org/netdev/20230908142919.14849-4-Parthiban.Veerasooran@xxxxxxxxxxxxx/T/
> 
> Yes it is. I wasn't aware of Microchip's work. Thanks for pointing it out.

I guess this patch is going to change a lot in future revisions...

Please double check the code with checkpatch before the next
submission, there are a few things that could be improved.

Specifically, avoid c++ style comments, and avoid using multiple label
names to jump into the same location - selecting the label name as the
target action will make the code more clear.

Thanks,

Paolo