Re: [RFC PATCH net-next 1/6] net: ethernet: implement OPEN Alliance control transaction interface

[Parthiban.Veerasooran]

Hi Andrew,

On 13/09/23 7:46 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> +struct oa_tc6 {
>> +     struct spi_device *spi;
>> +     bool ctrl_prot;
>> +};
> 
> Should this be considered an opaque structure which the MAC driver
> should not access the members?
> 
> I don't see anything setting ctrl_prot here. Does it need a setter and
> a getter?
Ah ok, it is supposed to be done in the oa_tc6_init() function. Somehow 
missed it. Will correct it in the next version.

Best Regards,
Parthiban V
> 
>          Andrew