Re: [PATCH for-v6.6] mfd: cs42l43: Use correct macro for new-style PM runtime ops

From: Lee Jones
Date: Tue Sep 19 2023 - 10:07:38 EST


On Tue, 19 Sep 2023, Lee Jones wrote:

> On Tue, 19 Sep 2023, Uwe Kleine-König wrote:
>
> > From: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> >
> > The code was accidentally mixing new and old style macros, update the
> > macros used to remove an unused function warning whilst building with
> > no PM enabled in the config.
> >
> > Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@xxxxxxxxxxxxxxxxxxxxx/
> > Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> > Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Acked-by: Lee Jones <lee@xxxxxxxxxx>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > Hello Linus,
> >
> > this patch was submitted on August 22 already, but -rc2 is still
> > unfixed. This makes allmodconfig builds on (at least) s390 and m68k
> > fail.
> >
> > Lee who should normally send this fix to you seems to be swamped in
> > other work and asked: "If anyone wants to submit this directly to Linus
> > before -rc1, please, be my guest."
> >
> > Voilà, I'm Lee's guest now :-)
>
> Thanks Uwe.

If Linus a) communicates an issue with this or b) doesn't pick it up
for a week, I'll add it to my mfd-fixes branch and submit a formal
pull-request.

--
Lee Jones [李琼斯]