Re: [PATCH v1 1/1] irqdomain: Check virq for 0 before use in irq_dispose_mapping()

[Andy Shevchenko]

On Tue, Aug 22, 2023 at 04:51:36PM +0300, Andy Shevchenko wrote:
> It's a bit hard to read the logic since we use virq before checking
> it for 0. Rearrange the code to make it better to understand.
> 
> This, in particular, should clearly answer the question whether caller
> need to perform this check or not, and we have plenty places for both
> variants, confirming a confusion.
> 
> Fun fact that the new code is shorter:
> 
>   Function                                     old     new   delta
>   irq_dispose_mapping                          278     271      -7
>   Total: Before=11625, After=11618, chg -0.06%
> 
> when compiled by GCC on Debian for x86_64.

Any comment on this?

-- 
With Best Regards,
Andy Shevchenko