Re: linux-next: Tree for Sep 19 (UML)

From: Nick Desaulniers
Date: Tue Sep 19 2023 - 17:18:49 EST


On Tue, Sep 19, 2023 at 08:42:07AM -0700, Randy Dunlap wrote:
>
>
> On 9/18/23 23:37, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20230918:
> >
> > New tree: kvm-ppc
> >
> > The mm tree gained a boot warning for which I reverted 5 commits.
> >
> > Non-merge commits (relative to Linus' tree): 5750
> > 3717 files changed, 446028 insertions(+), 107378 deletions(-)
> >
> > ----------------------------------------------------------------------------
> >
>
> on i386 or x86_64:
>
> ../arch/x86/um/../kernel/module.c: In function 'execmem_arch_params':
> ../arch/x86/um/../kernel/module.c:54:50: error: implicit declaration of function 'kaslr_enabled'; did you mean 'kasan_enabled'? [-Werror=implicit-function-declaration]
> 54 | if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_enabled())
> | ^~~~~~~~~~~~~
> | kasan_enabled
>
>
>
> git blames this on:
>
> commit 12633d679796
> Author: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Tue Sep 19 15:14:03 2023 +1000
>
> Revert "arch: make execmem setup available regardless of CONFIG_MODULES"
>
> This reverts commit 3300c3af20090ff5e03e5c4bf2ef2cfaa03d4e9b.

Thanks for the report, FWIW, our CI is hitting this, too.

Was 12633d679796 a pure revert, or was it manually modified?

Oh 3300c3 was patch 10/13; maybe a clean revert is not possible without
other reverts in addition?
https://lore.kernel.org/lkml/20230918072955.2507221-11-rppt@xxxxxxxxxx/

Seems like there's more info in this thread:
https://lore.kernel.org/lkml/20230919152031.GF3303@xxxxxxxxxx/