Re: [PATCH 0/5] Add the pci_get_base_class() helper and use it

From: suijingfeng
Date: Tue Sep 19 2023 - 22:46:55 EST


Hi,


On 2023/8/25 21:18, Deucher, Alexander wrote:
[Public]

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Sui
Jingfeng
Sent: Friday, August 25, 2023 2:27 AM
To: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Cc: alsa-devel@xxxxxxxxxxxxxxxx; Sui Jingfeng <suijingfeng@xxxxxxxxxxx>;
nouveau@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dri-
devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-
pci@xxxxxxxxxxxxxxx
Subject: [PATCH 0/5] Add the pci_get_base_class() helper and use it

From: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>

There is no function that can be used to get all PCI(e) devices in a system by
matching against its the PCI base class code only, while keep the sub-class code
and the programming interface ignored. Therefore, add the
pci_get_base_class() function to suit the need.

For example, if an application want to process all PCI(e) display devices in a
system, it can achieve such goal by writing the code as following:

pdev = NULL;
do {
pdev = pci_get_base_class(PCI_BASE_CLASS_DISPLAY, pdev);
if (!pdev)
break;

do_something_for_pci_display_device(pdev);
} while (1);

Sui Jingfeng (5):
PCI: Add the pci_get_base_class() helper
ALSA: hda/intel: Use pci_get_base_class() to reduce duplicated code
drm/nouveau: Use pci_get_base_class() to reduce duplicated code
drm/amdgpu: Use pci_get_base_class() to reduce duplicated code
drm/radeon: Use pci_get_base_class() to reduce duplicated code

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

Thanks a lot.


What to do next then?

By the way, Bjorn, what's your opinion?
I'm ask because I don't know what to do next with this series.

As they belong to different system of Linux kernel,
the rest of patch (0002 ~ 0005) depend on the first one.

I think, merge the 0001-patch firstly, then wait it arrive at drm-misc, alsa branch.
Or, to do something else?