Re: [PATCH] wifi: brcmfmac: Annotate struct brcmf_gscan_config with __counted_by

From: Kalle Valo
Date: Wed Sep 20 2023 - 07:14:34 EST


Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct brcmf_gscan_config.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Arend van Spriel <aspriel@xxxxxxxxx>
> Cc: Franky Lin <franky.lin@xxxxxxxxxxxx>
> Cc: Hante Meuleman <hante.meuleman@xxxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> Cc: Hector Martin <marcan@xxxxxxxxx>
> Cc: Ryohei Kondo <ryohei.kondo@xxxxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: brcm80211-dev-list.pdl@xxxxxxxxxxxx
> Cc: SHA-cyfmac-dev-list@xxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

cf74cdc6e581 wifi: brcmfmac: Annotate struct brcmf_gscan_config with __counted_by

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230915200542.never.417-kees@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches