Re: [PATCH v2 06/11] dt-bindings: timer: Add Sophgo sg2042 clint

From: Inochi Amaoto
Date: Wed Sep 20 2023 - 08:15:31 EST


>On 20/09/2023 08:39, Chen Wang wrote:
>> From: Inochi Amaoto <inochiama@xxxxxxxxxxx>
>>
>> Add two new compatible string formatted like `C9xx-clint-xxx` to identify
>> the timer and ipi device separately, and do not allow c900-clint as the
>
>Why?
>

If use the same compatible, SBI will process this twice in both ipi and
timer, use different compatible will allow SBI to treat these as different.
AFAIK, the aclint in SBI use the same concepts, which make hard to use the
second register range. I have explained in another response.

https://lore.kernel.org/all/IA1PR20MB495313B7E9B2FC529BE0BB2ABBF9A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

>You received comment about it, so please provide proper explanation in
>the commit msg.
>
>Same device does not get two different compatibles.
>
>You also did not respond to my comments, so you basically ignored it and
>send the same.
>
>NAK
>
>Best regards,
>Krzysztof
>

Sorry for this, as I mistake the idea of the last message. All of this
will be fixed in the next patch.