Re: [PATCH] checkpatch: stop complaining about tags suggested/tested by syzkaller
From: Andrew Kanner
Date: Wed Sep 20 2023 - 10:29:58 EST
On Tue, Aug 29, 2023 at 02:34:47PM +0200, Andrew Kanner wrote:
> If you submit a testing request to syzkaller it may reply with:
>
> syzbot has tested the proposed patch and the reproducer did not \
> trigger any issue:
>
> Reported-and-tested-by: syzbot+f817490f5bd20541b90a@xxxxxxxxxxxxxxxxxxxxxxxxx
>
> Checkpatch is ok with Reported-by tags, but complains about
> Reported-and-tested-by tags:
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 \
> chars per line)
> #48:
> Reported-and-tested-by: syzbot+f817490f5bd20541b90a@xxxxxxxxxxxxxxxxxxxxxxxxx
>
> Adding the new tag to signature_tags removes this warning.
>
> Signed-off-by: Andrew Kanner <andrew.kanner@xxxxxxxxx>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a9841148cde2..f85dcfb098e0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -615,6 +615,7 @@ our $signature_tags = qr{(?xi:
> Tested-by:|
> Reviewed-by:|
> Reported-by:|
> + Reported-and-tested-by:|
> Suggested-by:|
> To:|
> Cc:
> @@ -709,7 +710,7 @@ sub find_standard_signature {
> my ($sign_off) = @_;
> my @standard_signature_tags = (
> 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
> - 'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
> + 'Reviewed-by:', 'Reported-by:', 'Reported-and-tested-by:', 'Suggested-by:'
> );
> foreach my $signature (@standard_signature_tags) {
> return $signature if (get_edit_distance($sign_off, $signature) <= 2);
> --
> 2.39.3
>
Kindly reminder.
Please let me know if there're any objections.
--
Andrew Kanner