Re: [PATCH v2] vmscan: add trace events for lru_gen

[Steven Rostedt]

On Thu, 21 Sep 2023 09:12:30 -0700
"T.J. Mercier" <tjmercier@xxxxxxxxxx> wrote:

> > +       TP_fast_assign(
> > +               __entry->nid = nid;
> > +               __entry->nr_reclaimed = nr_reclaimed;
> > +               __entry->nr_dirty = stat->nr_dirty;
> > +               __entry->nr_writeback = stat->nr_writeback;
> > +               __entry->nr_congested = stat->nr_congested;
> > +               __entry->nr_immediate = stat->nr_immediate;
> > +               __entry->nr_activate0 = stat->nr_activate[0];
> > +               __entry->nr_activate1 = stat->nr_activate[1];
> > +               __entry->nr_ref_keep = stat->nr_ref_keep;
> > +               __entry->nr_unmap_fail = stat->nr_unmap_fail;
> > +               __entry->priority = priority;
> > +               __entry->reclaim_flags = trace_reclaim_flags(file);
> > +       ),
> > +
> > +       TP_printk("nid=%d nr_reclaimed=%ld nr_dirty=%ld nr_writeback=%ld nr_congested=%ld nr_immediate=%ld nr_activate_anon=%d nr_activate_file=%d nr_ref_keep=%ld nr_unmap_fail=%ld priority=%d flags=%s",  
> 
> Many of these values are unsigned so I think many of these format
> specifiers should be %lu instead of %ld.

Other than this, from the tracing POV:

Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve