Re: [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number

[Andy Shevchenko]

On Thu, Sep 21, 2023 at 05:00:26PM +0800, Wenhua Lin wrote:
> When the soc changes, the corresponding gpio-eic-sprd.c
> code needs to be modified, and the corresponding
> Document must also be modified, which is quite troublesome.
> To avoid modifying the driver file, the number of EICs
> is automatically calculated by matching dts nodes.

> Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@xxxxxxxxxx>

Same comment as per patch 1. Also, fixes needs to be grouped at the beginning
of the series. (I don't remember seeing Fixes tag in the patch 2.)

...

> +#define SPRD_EIC_VAR_DATA(soc_name)				\

Misindented \

> +static const struct sprd_eic_variant_data soc_name##_eic_dbnc_data = {	\
> +	.type = SPRD_EIC_DEBOUNCE,					\
> +};									\

...

>  	struct sprd_eic *sprd_eic;
>  	struct resource *res;

>  	int ret, i;
> +	u16 num_banks = 0;

Preserve reversed xmas tree order.

-- 
With Best Regards,
Andy Shevchenko