Re: [PATCH 5.4 000/367] 5.4.257-rc1 review

[Sui Jingfeng]

Hi,


On 2023/9/21 20:08, Naresh Kamboju wrote:
> On Wed, 20 Sept 2023 at 14:25, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > This is the start of the stable review cycle for the 5.4.257 release.
> > There are 367 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 22 Sep 2023 11:28:09 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.257-rc1.gz
> > or in the git tree and branch at:
> >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> Following build warnings noticed while building arm64 with allmodconfig
> on stable-rc 5.4 with gcc-8 and gcc-12 toolchains.
>
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
>
> drivers/gpu/drm/mediatek/mtk_drm_gem.c: In function 'mtk_drm_gem_prime_vmap':
> drivers/gpu/drm/mediatek/mtk_drm_gem.c:273:10: warning: returning
> 'int' from a function with return type 'void *' makes pointer from
> integer without a cast [-Wint-conversion]
>     return -ENOMEM;
>            ^


Well, this is easy to solve.
For the Linux-5.4 kernel, we should use "return -ERR_PTR(-ENOMEM)" instead of "return -ENOMEM".
Since, newer version kernel prefer to return error code instead of error pointer.
See below commit for more information.

commit <7e542ff8b463>  ("drm/mediatek: Use struct dma_buf_map in GEM 
vmap ops")
commit <49a3f51dfeee> ("drm/gem: Use struct dma_buf_map in GEM vmap ops 
and convert GEM backends")


> Links:
>   - https://storage.tuxsuite.com/public/linaro/lkft/builds/2VfG47LmPH9MUEuIcMVftu6NsFy/
>
>
> Following commit is causing this build warning.
>
> drm/mediatek: Fix potential memory leak if vmap() fail
> [ Upstream commit 379091e0f6d179d1a084c65de90fa44583b14a70 ]
>
> --
> Linaro LKFT
> https://lkft.linaro.org