Re: [PATCH v3 07/13] cpufreq: scmi: Drop redundant ifdef in scmi_cpufreq_probe()

[Sudeep Holla]

On Thu, Sep 21, 2023 at 03:02:16PM +0200, Ulf Hansson wrote:
> On Thu, 21 Sept 2023 at 13:14, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> >
> > On Fri, Aug 25, 2023 at 01:26:27PM +0200, Ulf Hansson wrote:
> > > We have stubs for devm_of_clk_add_hw_provider(), so there should be no need
> > > to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean
> > > up the code a bit.
> > >
> >
> > No exactly. The stub is under !CONFIG_OF but we need it for !CONFIG_COMMON_CLK.
> > The original build issue reported for which I add this was CONFIG_OF=y &&
> > CONFIG_COMMON_CLK=n.
> >
> > It looks like it is still valid combo though I don't have a handy randconfig
> > to present to you. I prefer to drop this for now if that is OK with you.
> 
> Sure, it's perfectly fine to drop it. It's just a thing I stumbled
> over that isn't really needed in the $subject series!
> 

Thanks !

-- 
Regards,
Sudeep