Re: [PATCH v2 net] net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent

From: Fabio Estevam
Date: Thu Sep 21 2023 - 13:28:34 EST


On Wed, Sep 20, 2023 at 3:47 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:

> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3012,14 +3012,16 @@ static void mv88e6xxx_hardware_reset(struct mv88e6xxx_chip *chip)
> * from the wrong location resulting in the switch booting
> * to wrong mode and inoperable.
> */
> - mv88e6xxx_g1_wait_eeprom_done(chip);
> + if (chip->info->ops->get_eeprom)
> + mv88e6xxx_g2_eeprom_wait(chip);

Just realized that I should also remove the
mv88e6xxx_g1_wait_eeprom_done() definition, as it becomes unused now.

I will send a v3 with such a change, but will wait for more comments first.