Re: [patch V3 10/30] x86/microcode/intel: Unify microcode apply() functions

[Borislav Petkov]

On Tue, Sep 12, 2023 at 09:57:59AM +0200, Thomas Gleixner wrote:
> Deduplicate the early and late apply() functions.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/microcode/intel.c |  105 +++++++++++-----------------------
>  1 file changed, 36 insertions(+), 69 deletions(-)
> 
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -294,12 +294,11 @@ static __init struct microcode_intel *sc
>  	return size ? NULL : patch;
>  }
>  
> -static enum ucode_state apply_microcode_early(struct ucode_cpu_info *uci, bool early)
> +static enum ucode_state apply_microcode(struct ucode_cpu_info *uci, struct microcode_intel *mc,

Err, we have

struct microcode_ops.apply_microcode()

already. Can we disambiguate those pls?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette