Re: [PATCH] dmaengine: imx-sdma: fix deadlock in interrupt handler

From: Fabio Estevam
Date: Thu Sep 21 2023 - 17:45:48 EST


Hi Tim,

On Thu, Sep 21, 2023 at 6:57 AM Tim van der Staaij | Zign
<Tim.vanderstaaij@xxxxxxxxxxxxx> wrote:
>
> dev_warn internally acquires the lock that is already held when
> sdma_update_channel_loop is called. Therefore it is acquired twice and
> this is detected as a deadlock. Temporarily release the lock while
> logging to avoid this.
>
> Signed-off-by: Tim van der Staaij <tim.vanderstaaij@xxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/AM0PR08MB308979EC3A8A53AE6E2D3408802CA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

checkpatch gives a warning on this patch:

WARNING: From:/Signed-off-by: email name mismatch: 'From: "Tim van der
Staaij | Zign" <Tim.vanderstaaij@xxxxxxxxxxxxx>' != 'Signed-off-by:
Tim van der Staaij <tim.vanderstaaij@xxxxxxxxxxxxx>'

Should it contain a Fixes tag so that it can be backported to older
stable-kernels?

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>