Re: [PATCH v3 3/5] arm64: dts: qcom: sm4450: Add RPMH and Global clock

[Tengfei Fan]

在 9/20/2023 6:00 PM, Konrad Dybcio 写道:
> On 9/20/23 08:54, Tengfei Fan wrote:
> > Add device node for RPMH and Global clock controller on Qualcomm
> > SM4450 platform.
> >
> > Signed-off-by: Ajit Pandey <quic_ajipan@xxxxxxxxxxx>
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm4450.dtsi | 23 +++++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi 
> > b/arch/arm64/boot/dts/qcom/sm4450.dtsi
> > index 3d9d3b5e9510..c27f17a41699 100644
> > --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
> > @@ -3,6 +3,8 @@
> >    * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights 
> > reserved.
> >    */
> > +#include <dt-bindings/clock/qcom,rpmh.h>
> > +#include <dt-bindings/clock/qcom,sm4450-gcc.h>
> These should be sorted alphabetically.Yes, I will sort these alphabetically.
>
> [...]
>
> > +            rpmhcc: clock-controller {
> > +                compatible = "qcom,sm4450-rpmh-clk";
> > +                #clock-cells = <1>;
> > +                clock-names = "xo";
> > +                clocks = <&xo_board>;
> property
> property-names
>
> Konrad
Hi Konrad,
Sure, I will adjust these noeds.

--
Thx and BRs,
Tengfei Fan