Re: [PATCH v3 1/2] i2c: rcar: reset controller is mandatory for Gen3+

From: Geert Uytterhoeven
Date: Fri Sep 22 2023 - 03:06:03 EST


On Thu, 21 Sep 2023, Wolfram Sang wrote:
Initially, we only needed a reset controller to make sure RXDMA works at
least once per transfer. Meanwhile, documentation has been updated. It
now says that a reset has to be performed prior every transaction, even
if it is non-DMA. So, make the reset controller a requirement instead of
being optional. And bail out if resetting fails.

Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
---

Change since v2:
* properly bail out on errors using goto
To make that easier, the reset controller is now probed after the
handling of pm_runtime_put() is determined

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds