Re: [PATCH] ptp: ocp: Fix error handling in ptp_ocp_device_init

From: Vadim Fedorenko
Date: Fri Sep 22 2023 - 07:28:58 EST


On 22/09/2023 10:40, Dinghao Liu wrote:
When device_add() fails, ptp_ocp_dev_release() will be called
after put_device(). Therefore, it seems that the
ptp_ocp_dev_release() before put_device() is redundant.

Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>

Thanks!

Reviewed-by: Vadim Feodrenko <vadim.fedorenko@xxxxxxxxx>