Re: [PATCH v2] sched: fix warning in bandwidth distribution

From: Josh Don
Date: Fri Sep 22 2023 - 18:59:04 EST


On Fri, Sep 22, 2023 at 1:13 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> So instead of uglifying the code with seldom-tested !CONFIG_SMP #ifdefs,
> please fold the !SMP code into SMP code: make ->throttled_csd_list
> unconditional in a preparatory patch (even if it's essentially unused on
> !SMP), then add what is basically your v1 patch as a second patch in the
> series to fix the bug.
>
> We want to unify as much of the SMP and !SMP codepaths as possible, even
> when it casuses a bit of runtime overhead for !SMP.

Yep, makes perfect sense, I'll respin this patch.

Thanks,
Josh