Re: [PATCH 2/4] dt-bindings: clock: qcom,camcc.yaml: Add sc8280xp CAMCC compatible

[Krzysztof Kozlowski]

On 23/09/2023 17:00, Bryan O'Donoghue wrote:
> Document sc8280xp camcc as a new compat string with the same
> requirements as sm8250 and sm8450.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/clock/qcom,camcc.yaml |   2 +
>  .../dt-bindings/clock/qcom,camcc-sc8280xp.h   | 179 ++++++++++++++++++
>  2 files changed, 181 insertions(+)
>  create mode 100644 include/dt-bindings/clock/qcom,camcc-sc8280xp.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,camcc.yaml
> index 81807b8e0d24..456d304cbea8 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,camcc.yaml
> @@ -30,6 +30,7 @@ properties:
>      enum:
>        - qcom,sc7180-camcc
>        - qcom,sc7280-camcc
> +      - qcom,sc8280xp-camcc
>        - qcom,sdm845-camcc
>        - qcom,sm6350-camcc
>        - qcom,sm8250-camcc
> @@ -127,6 +128,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sc8280xp-camcc
>              - qcom,sm8250-camcc
>              - qcom,sm8450-camcc
>      then:
> diff --git a/include/dt-bindings/clock/qcom,camcc-sc8280xp.h b/include/dt-bindings/clock/qcom,camcc-sc8280xp.h
> new file mode 100644
> index 000000000000..867fbd146ee4
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,camcc-sc8280xp.h

Filename must match compatible (thus follow common naming scheme - SoC-IP).

Best regards,
Krzysztof