Re: [PATCH 2/2] media: i2c: gc2145: Galaxy Core GC2145 sensor support
From: kernel test robot
Date: Tue Sep 26 2023 - 12:22:01 EST
Hi Alain,
kernel test robot noticed the following build warnings:
[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v6.6-rc3 next-20230926]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alain-Volmat/dt-bindings-media-i2c-add-galaxycore-gc2145-dt-bindings/20230926-173518
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20230926092825.819229-3-alain.volmat%40foss.st.com
patch subject: [PATCH 2/2] media: i2c: gc2145: Galaxy Core GC2145 sensor support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230927/202309270018.GBMyNvxU-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230927/202309270018.GBMyNvxU-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309270018.GBMyNvxU-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/media/i2c/gc2145.c:1140:12: warning: 'gc2145_resume' defined but not used [-Wunused-function]
1140 | static int gc2145_resume(struct device *dev)
| ^~~~~~~~~~~~~
>> drivers/media/i2c/gc2145.c:1129:12: warning: 'gc2145_suspend' defined but not used [-Wunused-function]
1129 | static int gc2145_suspend(struct device *dev)
| ^~~~~~~~~~~~~~
vim +/gc2145_resume +1140 drivers/media/i2c/gc2145.c
1128
> 1129 static int gc2145_suspend(struct device *dev)
1130 {
1131 struct v4l2_subdev *sd = dev_get_drvdata(dev);
1132 struct gc2145 *gc2145 = to_gc2145(sd);
1133
1134 if (gc2145->streaming)
1135 gc2145_stop_streaming(gc2145);
1136
1137 return 0;
1138 }
1139
> 1140 static int gc2145_resume(struct device *dev)
1141 {
1142 struct v4l2_subdev *sd = dev_get_drvdata(dev);
1143 struct gc2145 *gc2145 = to_gc2145(sd);
1144 struct v4l2_subdev_state *state;
1145 int ret;
1146
1147 if (gc2145->streaming) {
1148 state = v4l2_subdev_lock_and_get_active_state(sd);
1149 ret = gc2145_start_streaming(gc2145, state);
1150 v4l2_subdev_unlock_state(state);
1151 if (ret)
1152 goto error;
1153 }
1154
1155 return 0;
1156
1157 error:
1158 gc2145_stop_streaming(gc2145);
1159 gc2145->streaming = false;
1160
1161 return ret;
1162 }
1163
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki