On 2023-09-27 15:06:03+0200, Rodrigo Campos wrote:
On 9/27/23 01:30, Thomas Weißschuh wrote:
On 2023-09-26 15:36:47+0200, Rodrigo Campos wrote:We can definitely remove that struct statx bits in our vendoring. It will
simplify updating if we don't have to patch it, so if we can't include a fix
in nolibc, I think we will continue doing the hack ourselves and that is
all. It is not too bad :)
How often are you planning on updating your vendoring?
In the timeframe before you are dropping centos-7 support?
The "nice" thing about the breakage is that it will break loudly during
compilation so it will be easy to notice and fix it up.
I don't think it is worth for nolibc, at least for this use case, to
reintroduce compatibility for stat() without statx().
It wouldn't even be full compatibility. The code would compile but be
unusuable for stat()/statx(). And I don't think any application expects
stat() to return -ENOSYS.
It's a bit ugly code to support a kernel that has been EOL upstream for
six years for a fairly specific usecase.
But who knows, maybe Willy has a soft spot for the 3.10 kernel :-)
Let's wait for his input.