RE: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().

From: David Laight
Date: Thu Sep 28 2023 - 04:10:34 EST


From: Andrew Morton
> Sent: 27 September 2023 18:30
>
> On Mon, 18 Sep 2023 08:14:40 +0000 David Laight <David.Laight@xxxxxxxxxx> wrote:
>
> > A quick grep shows 5734 min() and 4597 min_t().
> > Having the casts on almost half of the calls shows that something
> > is clearly wrong.

Thanks for taking these.
I had a horrid thought they were languishing again.

> My preferred approach to fixing min() warnings is "the types are wrong".
> But often getting the types better is hard.
>
> Is there a plan afoot to go around existing code doing some
> min_t()->min() conversions?

Could get tedious given there are 4500+ min_t() out there.
Also every one needs looking at just to check it isn't relying
on the cast - a few do,

But they could get reduced slowly.
Not adding more would be a bonus!

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)