Re: [PATCH v2 2/4] KVM: x86: add more information to the kvm_entry tracepoint

[Maxim Levitsky]

У вт, 2023-09-26 у 18:39 +0200, Paolo Bonzini пише:
> On 9/24/23 14:44, Maxim Levitsky wrote:
> > +		__field(	u32,		inj_info	)
> > +		__field(	u32,		inj_info_err	)
> > +		__field(	bool,		guest_mode	)
> > +		__field(	bool,		req_imm_exit	)
> > +		),
> 
> As anticipated in patch 1 I'm not so sure about adding req_imm_exit here 
> but also (especially) in kvm_exit.  I do believe it should be traced, 
> I'm not sure it's needed in kvm_entry+kvm_exit as opposed to just a 
> separate tracepoint.


I will drop guest_mode.

Best regards,
	Maxim Levitsky


> 
> Paolo
>