RE: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data in the match tables

[Biju Das]

Hi Lee Jones,

> -----Original Message-----
> From: Lee Jones <lee@xxxxxxxxxx>
> Sent: Thursday, September 28, 2023 2:44 PM
> To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Pavel Machek <pavel@xxxxxx>;
> linux-leds@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Biju Das
> <biju.das.au@xxxxxxxxx>
> Subject: Re: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data
> in the match tables
> 
> On Mon, 25 Sep 2023, Andy Shevchenko wrote:
> 
> > On Sat, Sep 23, 2023 at 06:19:20PM +0100, Biju Das wrote:
> > > Convert enum->pointer for data in the match tables, so that
> > > device_get_match_data() can do match against OF/ACPI/I2C tables,
> > > once i2c bus type match support added to it.
> > >
> > > Replace enum->struct *pca955x_chipdefs for data in the match table.
> > > Simplify the probe() by replacing device_get_match_data() and ID
> > > lookup for retrieving data by i2c_get_match_data().
> > >
> > > While at it, add const definition to pca955x_chipdefs[].
> >
> > ...
> >
> > > -	struct pca955x_chipdef	*chipdef;
> > > +	const struct pca955x_chipdef	*chipdef;
> >
> > No need to preserve TAB(s) here.
> 
> Follow-up please.

Sure will send a follow-up patch to fix this tab issue as it is a separate change.

Cheers,
Biju