Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions

[Christian Lamparter]

On 9/29/23 08:49, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 09:43:03AM +0300, Dan Carpenter wrote:
> > I don't know anything which would warn about this.  Generally, in the
> > kernel we try to avoid casts but perhaps there was a static checker
> > which likes casts?
> >
> > If removing these sorts of casts were an issue we would have known by
> > now.
>
> Thinking about it more, if this caused a static checker warning then
> probably every kmalloc() would need a cast.

Oh, we do have our fair share of static checker noise in:
drivers/net/wireless/ath/ (this is where carl9170 is located)!

I would like to take the chance to again point to this beauty:
<https://lore.kernel.org/linux-wireless/TYAP286MB03154F9AAFD4C35BEEDE4A99BC4CA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/#mf1b8919a000fe661803c17073f48b3c410888541>
@Dan, @Jeff can you please comment on that too?

As for this patch: If Wu ran some compiles with
what GCC version he has available and nothing turned up:

Acked-by: Christian Lamparter <chunkeey@xxxxxxxxx>

Regards,
Christian