Re: [PATCH v3 19/27] staging: iio: resolver: ad2s1210: add phase lock range support

From: Jonathan Cameron
Date: Sat Sep 30 2023 - 11:18:29 EST


On Fri, 29 Sep 2023 12:23:24 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> From: David Lechner <david@xxxxxxxxxxxxxx>
>
> From: David Lechner <dlechner@xxxxxxxxxxxx>
>
> The AD2S1210 chip has a phase lock range feature that allows selecting
> the allowable phase difference between the excitation output and the
> sine and cosine inputs. This can be set to either 44 degrees (default)
> or 360 degrees.
>
> This patch adds a new phase channel with a threshold event that can be
> used to configure the phase lock range. Actually emitting the event
> will be added in a subsequent patch.
>
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> ---
Looks good to me.