Re: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode
From: Andrey Konovalov
Date: Sun Oct 01 2023 - 02:59:11 EST
On Sat, Sep 30, 2023 at 12:13 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Fri, Sep 29, 2023 at 11:06 PM Alexander Potapenko <glider@xxxxxxxxxx> wrote:
> >
> > (CC Masahiro Yamada)
> >
> > On Thu, Sep 28, 2023 at 6:16 AM Joey Jiao <quic_jiangenj@xxxxxxxxxxx> wrote:
> > >
> > > Fow low memory device, full enabled kasan just not work.
> > > Set KASAN_SANITIZE to n when CONFIG_KASAN_WHITELIST_ONLY=y.
> > > So we can enable kasan for single file or module.
> >
> > I don't have technical objections here, but it bothers me a bit that
> > we are adding support for KASAN_SANITIZE:=y, although nobody will be
> > adding KASAN_SANITIZE:=y to upstream Makefiles - only development
> > kernels when debugging on low-end devices.
> >
> > Masahiro, is this something worth having in upstream Kconfig code?
>
>
> Even if we apply this patch to the upstream,
> you will end up with adding 'KASAN_SANITIZE :=y'
> to the single file/Makefile.
>
> I am not convinced with this patch
> since this nod is not so useful standalone.
Yeah, I agree here, I don't think this change belongs as is in the
upstream KASAN code.