Re: [PATCH] net/sched: use spin_lock_bh() on &gact->tcf_lock

[Cong Wang]

On Tue, Sep 26, 2023 at 11:27 AM Chengfeng Ye <dg573847474@xxxxxxxxx> wrote:
>
> I find tcf_gate_act() acquires &gact->tcf_lock without disable
> bh explicitly, as gact->tcf_lock is acquired inside timer under
> softirq context, if tcf_gate_act() is not called with bh disable
> by default or under softirq context(which I am not sure as I cannot
> find corresponding documentation), then it could be the following
> deadlocks.

Did you find this during code review or did you see a real
lockdep splat? If the latter, please include the full lockdep log.

Thanks.