Re: [PATCH v3 6/6] ARM: dts: qcom: add device tree for Nokia Lumia 830

[Konrad Dybcio]

On 10/1/23 00:08, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 830, codenamed
> "tesla".
>
> Co-developed-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Co-developed-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Co-developed-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Rayyan Ansari <rayyan@xxxxxxxxx>
> ---
>   arch/arm/boot/dts/qcom/Makefile               |  1 +
>   .../dts/qcom/qcom-msm8926-microsoft-tesla.dts | 67 +++++++++++++++++++
>   2 files changed, 68 insertions(+)
>   create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 7982620ec9f9..a3d293e40820 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>   	qcom-msm8916-samsung-grandmax.dtb \
>   	qcom-msm8916-samsung-serranove.dtb \
>   	qcom-msm8926-microsoft-superman-lte.dtb \
> +	qcom-msm8926-microsoft-tesla.dtb \
>   	qcom-msm8960-cdp.dtb \
>   	qcom-msm8960-samsung-expressatt.dtb \
>   	qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
> new file mode 100644
> index 000000000000..53a6d4e85959
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
> @@ -0,0 +1,67 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <jm5112356@xxxxxxxxx>
> + * Copyright (c) 2023, Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> + * Copyright (c) 2023, Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> + * Copyright (c) 2023, Rayyan Ansari <rayyan@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/* This device has touchscreen on i2c1 instead */
> +/delete-node/ &touchscreen;
> +
> +/ {
> +	model = "Nokia Lumia 830";
> +	compatible = "microsoft,tesla", "qcom,msm8926", "qcom,msm8226";
"we have a Tesla at home"

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad