Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case

From: Joe Perches
Date: Mon Oct 02 2023 - 05:43:51 EST


On Mon, 2023-10-02 at 08:39 +0200, Vlastimil Babka wrote:
> On 10/2/23 08:26, Christoph Hellwig wrote:
> > > + * If the invalidate lock is not held, the folio was in cache and
> > > + * uptodate and now it is not. Strange but possible since we
> >
> > Please don't spill block comments ôver the 80 charater limit, that makes
> > them impossible to read nicely.
>
> Joe, can we revert the default to 80 to avoid everyone having to alias
> --max-line-length=80 locally?

Given the current --max-line-length default is 100,
and that was Linus' preference, I think not.

https://lore.kernel.org/lkml/CAHk-=wj3iGQqjpvc+gf6+C29Jo4COj6OQQFzdY0h5qvYKTdCow@xxxxxxxxxxxxxx/

and

https://lore.kernel.org/lkml/CAHk-=wjR0H3+2ba0UUWwoYzYBH0GX9yTf5dj2MZyo0xvyzvJnA@xxxxxxxxxxxxxx/